mudler / mudler/vllm.cpp

Benchmark: record AMD GPU clocks in leased ROCm runs

Open
#2,381 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
423
Forks
53
Avg merge
20h 26m
Merged PRs (30d)
310

Description

Row: BENCH-ROCM-CLOCK-STATE

tools/bench/gpu_clock_state.py records NVIDIA clock state through nvidia-smi. It cannot attribute a benchmark on strix:gpu0, where the worker exposes AMD sysfs state and no rocm-smi command.

The measured Strix interface is:

/sys/class/drm/card1/device/pp_dpm_sclk
0: 600Mhz
1: 621Mhz *
2: 2900Mhz
/sys/class/drm/card1/device/gpu_busy_percent
0

The existing DFlash2 harness can run without a clock summary only by refusing the result. A custom sampler does not satisfy the repository benchmark protocol.

Add an AMD provider to the committed helper. Keep the current NVIDIA output and decisions unchanged. The AMD record must include the resolved DRM device, active SCLK samples, maximum SCLK, busy samples, boot ID, driver identity, and the sample count inside each measured window. AMD-specific checks must not invent NVIDIA persistence-mode or throttle fields.

Acceptance:

  • Unit tests cover AMD sysfs discovery, parsing, device ambiguity, field changes, idle windows, and cross-arm comparisons.
  • Existing NVIDIA tests remain unchanged and green.
  • A leased Strix workload produces a clock record with at least 30 busy samples.
  • The DFlash2 benchmark harness accepts the AMD record only when its vendor-specific clock rules pass.
  • The final evidence states the exact workload, source revision, model hashes, device identity, boot ID, and contention state.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tools/bench/gpu_clock_state.py and its existing NVIDIA provider and tests, then trace how the DFlash2 harness validates clock records. Verify the AMD sysfs discovery and sampling cases named in the acceptance criteria, while keeping NVIDIA behavior unchanged. Done means a leased Strix run produces a compliant record with at least 30 busy samples and the harness accepts it only when AMD-specific rules pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, python
Domain
performance, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.