DFlash2 W3 tests use POSIX unistd APIs and cannot compile on native Windows
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 423
- Forks
- 53
- Avg merge
- 20h 26m
- Merged PRs (30d)
- 310
Description
SPEC-DFLASH2 W3 adds two binding suites that unconditionally include POSIX-only unistd.h: ests/vllm/v1/spec_decode/test_dflash2_runner_reach.cpp:54 and ests/vllm/models/test_qwen3_dflash2_draft.cpp:46. MSVC fails with C1083 before either suite can run. This blocks the mandatory mutation that deletes the production selector call site and proves the reachability gate turns red.\n\nOwner: SPEC-DFLASH2 W3 repair flow. Replace the POSIX temporary-file handling with the repository's portable fixture pattern or a correct platform-specific adapter. Port both suites, prove the unchanged tests green on native Windows, and run the production-call-site deletion mutation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/vllm/v1/spec_decode/test_dflash2_runner_reach.cpp:54 and tests/vllm/models/test_qwen3_dflash2_draft.cpp:46, then inspect the repository's portable fixture pattern for the temporary-file handling. Port both suites, run the unchanged tests on native Windows, and verify the production-call-site deletion mutation turns the reachability gate red.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100