mudler / mudler/luet

Refactor: Review semver comparations inside version.go to simplify migrations

Open
#79 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/funtoo enhancement refactoring
Dominant language
Go
Stars
307
Forks
30
PR merge metrics
No merged PRs in 30d

Description

Currently, Best() method uses directly the semver API and we need to duplicate the workaround for build version with the underscore or invalid chars. The idea is to separate the logic to a unique and specific point.
In this way, will be easier to replace semver with a fork or others

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read version.go and trace the Best() method's direct use of the semver API, including the workaround for build versions with underscores or invalid characters. The refactor is complete when this workaround is isolated at one specific point so replacing semver for migrations does not require duplicated logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.