mt-mods / mt-mods/technic

Sonic screwdriver causes issues with wallmounted, colorwallmounted, etc.

Open
#267 5 comments 0 reactions 0 assignees View on GitHub

@Emojigit is already working on this.

Since Jul 17, 2024.

  • #368 by @Emojigit — open
  • #405 by @S-S-X — open
Bug Controversial
Dominant language
Lua
Stars
23
Forks
33
PR merge metrics
No merged PRs in 30d

Description

see issue https://github.com/mt-mods/homedecor_modpack/issues/33

as @OgelGames calls it, a feature bug, the mtg screwdriver mod has advanced a lot since https://github.com/mt-mods/technic/blob/bc9a7759f3d902d2c72cd2763fe08e0e9fce4340/technic/tools/sonic_screwdriver.lua#L7 for instance wallmounted and colorwallmounted support have been added https://github.com/minetest/minetest_game/blob/master/mods/screwdriver/init.lua#L68-L83 as well as the on_rotate field. additionally https://github.com/mt-mods/technic/blob/bc9a7759f3d902d2c72cd2763fe08e0e9fce4340/technic/tools/sonic_screwdriver.lua#L66 should check minetest.is_creative_enabled which is per player rather than global

  • respect on_rotate
  • update to support (color)wallmounted nodes
  • #268

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with technic/tools/sonic_screwdriver.lua, especially the referenced lines, and compare it with minetest_game/mods/screwdriver/init.lua lines 68-83. Review open pull requests #368 and #405 before making changes. Done means the screwdriver respects on_rotate, supports wallmounted and colorwallmounted nodes, and handles creative mode per player as listed in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.