mt-mods / mt-mods/pipeworks

Wrong flow logic regarding Airtight Pipe entry/exit

Open
#56 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
20
Forks
31
Avg merge
1m
Merged PRs (30d)
9

Description

Placing a pipe on the side of Airtight Pipe entry/exit causes wierd water flow behaviour.

How to reproduce:

  • Place Pump/Intake Module to the water.
  • Go one node above it and place a pipe there.
  • Go one node to the west and place a pipe there.
  • Go one node to the west and place an Airtight Pipe entry/exit there, oriented west-east (this will connect to the tube segment).
  • Go one node to the west and place a pipe there.
  • Go one node to the north and place a pipe there.
  • Go one node to the east and place a pipe there.
  • Enable the Pump/Intake Module and wait till all pipe segments get loaded.
  • Disable the Pump/Intake Module.

Expected behaviour: After disabling the pump, all pipe segments should become empty.

Observed behaviour: Pipe segments are switching between empty and loaded state periodically, probably due to error in the flow logic.

Used Minetest 5.6.1 (Minetest Game) with basic_materials, dreambuilder_hotbar, pipeworks and unified_inventory mods.

screenshot_20230122_072118

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the listed Minetest setup and placement sequence, focusing on the Airtight Pipe entry/exit and the adjacent pipe loop. Inspect the pipeworks flow logic responsible for loading and emptying connected segments after the pump is disabled. Done means all segments remain empty instead of periodically switching between empty and loaded states.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.