mt-mods / mt-mods/missions

crash on high xp value

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
4
Forks
8
PR merge metrics
No merged PRs in 30d

Description

2021-02-21 19:02:45: ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'missions' in callback environment_Step(): /data/world//worldmods/missions/steps/checkxp.lua:43: attempt to compare nil with number
2021-02-21 19:02:45: ERROR[Main]: stack traceback:
2021-02-21 19:02:45: ERROR[Main]: 	/data/world//worldmods/missions/steps/checkxp.lua:43: in function 'on_step_enter'
2021-02-21 19:02:45: ERROR[Main]: 	/data/world//worldmods/missions/executor.lua:112: in function 'update_mission'
2021-02-21 19:02:45: ERROR[Main]: 	/data/world//worldmods/missions/executor.lua:192: in function 'func'
2021-02-21 19:02:45: ERROR[Main]: 	...ocal/share/minetest/builtin/profiler/instrumentation.lua:106: in function 'globalstep'
2021-02-21 19:02:45: ERROR[Main]: 	/data/world//worldmods/monitoring/builtin/globalstep.lua:32: in function </data/world//worldmods/monitoring/builtin/globalstep.lua:24>
2021-02-21 19:02:45: ERROR[Main]: 	/usr/local/share/minetest/builtin/game/register.lua:429: in function </usr/local/share/minetest/builtin/game/register.lua:413>
2021-02-21 19:02:45: ERROR[Main]: stack traceback:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting worldmods/missions/steps/checkxp.lua at line 43, then trace the call from worldmods/missions/executor.lua. Reproduce the high-XP mission step if possible and verify that the comparison no longer crashes when XP is missing or unusually large.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.