find_first_notloaded_dll() seems to not give good results in many cases
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 240
- Forks
- 60
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 1
Description
This is not a critical issue, but some annoying thing that hits people using shared libraries. If some dependency of those libraries is missing, the runtime reports a misleading error showing the name of the first library. The error is misleading because that named library might exist, indeed, while it's a third level dependency the one actually missing.
This was discussed in https://github.com/msys2/setup-msys2/issues/126.
I think the code responsible is here: https://github.com/msys2/msys2-runtime/blob/0eee28b4ad46bcf4ed60d6bb612dc1e477b639b1/winsup/cygwin/pinfo.cc#L115
In particular
find_first_notloaded_dll()seems to not give good results in many cases..
As said, this is not critical; but just something to be aware of.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in winsup/cygwin/pinfo.cc at find_first_notloaded_dll(), and review the discussion in msys2/setup-msys2#126. Reproduce a shared-library failure involving a missing third-level dependency, then determine whether the reported name identifies the actually missing library rather than the first library; done means the runtime error is no longer misleading in those cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100