msgbyte / msgbyte/tianji

[CAUTION] Support wider range of browsers

Open
#40 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.1k
Forks
194
Avg merge
18m
Merged PRs (30d)
3

Description

A proposal not to use the newer language syntax without polyfill, or to protect against exceptions. My Sentry got an error from the Umami script. On Chrome 83, an exception occurred with a missing formal parameter error. I haven't had this happen with tianji yet, but since you're taking a cue from Umami, I'm letting you know that I've had this happen and that you should be careful about supporting only newer browsers.

https://github.com/umami-software/umami/issues/2621

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the TypeScript browser-facing code and the linked Umami issue for the reported Chrome 83 “missing formal parameter” exception. The issue is done when the Tianji script avoids the unsupported syntax or handles the exception and works on the browser range the project intends to support.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.