mscdex / mscdex/ssh2

[feature-request] Add support for nodejs net.blockList object in ssh2.Server

Open
#1,477 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
5.8k
Forks
734
PR merge metrics
No merged PRs in 30d

Description

Hi

Please can you add support for the net.blockList object (added in Node 15) in the server configuration options to block unwanted connections?

I'm currently using the following code to achieve this on client connections, but it would be more efficient to pass it on to Node's server object.

if (blockList.check(connectionInfo.ip)) {
  client._sock.resetAndDestroy();
  return;
}

Niki

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how ssh2.Server consumes server configuration options and how those options reach Node's server object. Check the Node.js net.blockList API and the existing server tests; done means a configured blockList can block unwanted connections without requiring the client-side workaround described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
backend, networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.