ms-structural / ms-structural/femdesign-api
Refactor casting from derived classes bar reinforcement classes to parent
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 51
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
Refactor casting from derived classes bar reinforcement classes:
StirrupReinforcementLongitudinalBarReinforcement
to parent
BarReinforcement
Replace https://github.com/strusoft/femdesign-api/blob/6618ba3fad87807629e5bcbc2af93b6026d83dcc/FemDesign.Core/Bars/Bar.cs#L82 with separete Stirrups and LongitudinalBar fields.
Place casting between derived and parent classes at Model class level in Get/Set reinforcement methods.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with FemDesign.Core/Bars/Bar.cs at line 82, then inspect the Model class's Get/Set reinforcement methods and the StirrupReinforcement, LongitudinalBarReinforcement, and BarReinforcement classes. The refactor is done when casting occurs at Model level and Bar.cs uses separate Stirrup and LongitudinalBar fields as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100