ms-structural / ms-structural/femdesign-api
EdgeConnection identifier
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 51
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
What
Edge connections have an identifier and instance number in FEM-Design.
This should be possible to set to a custom value using our API.
Current
Currently only the library name can be set (#365).
But the edge connection identifier is hard-coded here:
https://github.com/strusoft/femdesign-api/blob/a338ed7602c19cace46751ea551096686b5a02cc/FemDesign.Core/Geometry/Region.cs#L190
https://github.com/strusoft/femdesign-api/blob/a338ed7602c19cace46751ea551096686b5a02cc/FemDesign.Core/Geometry/Region.cs#L225
The EdgeConnection constructors is missing the identifier name.
Maybe EdgeConnection should inherit from NamedEntityBase or implement the INamedEntity. But it might not be possible since the "@" might not be allowed in an edge connection identifier. I don't know.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the EdgeConnection constructors and the two hard-coded identifier locations in FemDesign.Core/Geometry/Region.cs at the referenced lines. Compare the existing library-name handling and NamedEntityBase/INamedEntity usage, then confirm the API can accept a custom edge connection identifier while preserving valid FEM-Design output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100