ms-structural / ms-structural/femdesign-api
Move ApplyChanges to RunDesign
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 51
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
I think it makes more sense to have ApplyChanges on the RunDesign method:
C# like this:
femDesign.RunDesign(CmdUserModule.STEELDESIGN, design, applyDesign: true);
And grasshopper like this:
Originally posted by @xRadne in https://github.com/strusoft/femdesign-api/issues/539#issuecomment-1323395709
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ApplyChanges and RunDesign definitions and their call sites, then inspect how the C# API and Grasshopper integration expose them. Check the existing tests or examples around these entry points. Done means the requested RunDesign option is consistently represented in both interfaces without leaving the old placement ambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100