ms-structural / ms-structural/femdesign-api
Consider removing LoadCase input in Model.Create
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 51
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
I find not necessary to "plug in" the LoadCase object in Grasshopper as we already use the object to construct the Loads.
The idea is to get the uniqueLoadCase from the ILoad element and create those from that list
Pro
Quicker model set up and less spaghetti grasshopper script
Cons
The user can not create a LoadCase if it is not assigned to any Load (why should it needs to create a load case if he is not using it?)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Model.Create and tracing how LoadCase and ILoad are currently passed and used. Review the three issue comments for context, then determine whether LoadCase objects can be derived from the unique load cases in ILoad elements; done means the API behavior and the implications for unassigned LoadCase objects are agreed and covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api, backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100