ms-structural / ms-structural/femdesign-api

`LoadGroupToLoadComb` doesn't take moving loads into account.

Open
#1,157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:bug
Dominant language
C#
Stars
51
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Issue:
https://github.com/strusoft/femdesign-api/blob/19f2a93505b7a54293e57934e64f03d87de3a1a0/FemDesign.Grasshopper/Loads/Load%20groups/LoadGroupToLoadComb.cs#L80

Load groups of moving loads are deserialized, but not recognized in the code, so they are not included in load combination generation.

This can mislead the user if they do not check the generated combinations, and they can get a false analysis or design result!

Sample file:
mvlLoad.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at FemDesign.Grasshopper/Loads/Load groups/LoadGroupToLoadComb.cs around line 80 and inspect how deserialized moving-load groups are handled during load-combination generation. Use mvlLoad.zip to reproduce the case; done means moving-load groups are recognized and included in the generated combinations.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.