ms-structural / ms-structural/femdesign-api

Edge connection endpoint behaviour missing from GH

Open
#1,104 1 comment 0 reactions 1 assignee View on GitHub

@lorinczandrea is already working on this.

Since Oct 23, 2024.

framework:grasshopper request:user type:feature
Dominant language
C#
Stars
51
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Note 1:

This feature exists in the API, but hasn't been implemented in the Grasshopper toolkit yet.

https://github.com/strusoft/femdesign-api/blob/82dbe19bc77b41afc932a58e7a3a2e6efdd9a375/FemDesign.Core/Shells/EdgeConnectionBase.cs#L9-L19

Note 2:

EdgeConnection.JoinedStartPoint and EdgeConnection.JoinedEndPoint properties must be true by default, as they are in FEM-Design.

FEM-Design functionality:

image

Tasks

  • Add new parameters to the existing EdgeConnection constructor or create a new one or add a new method to the class to set the endpoint behaviour attributes.

https://github.com/strusoft/femdesign-api/blob/82dbe19bc77b41afc932a58e7a3a2e6efdd9a375/FemDesign.Core/Shells/EdgeConnection.cs#L78-L89

EdgeConnection.MovingLocal, EdgeConnection.JoinedStartPoint and EdgeConnection.JoinedEndPoint should be added to the constructor as input parameters. E.g.:

private EdgeConnection(Releases.RigidityDataType3 rigidity, string libraryName = null, bool movingLocal = false, bool joinedStartPoint = true, bool joinedEndPoint = true)
        {
            EntityCreated();
            MovingLocal = movingLocal;
            JoinedStartPoint = joinedStartPoint;
            JoinedEndPoint = joinedEndPoint;

            if (libraryName is null)
                this.Rigidity = rigidity;
            else
                this.PredefRigidity = new Releases.RigidityDataLibType3(rigidity, libraryName);
        }
  • The MovingLocal property controls the functionality shown in the picture below:

image

  • Create a new "EndPointBehaviour" GH component.

  • Update existing EdgeConnection GH components (EdgeConnection.Construct, EdgeConnection.Hinged, EdgeConnection.Rigid). Add "EndPointBehaviour" as an input parameter.

  • Update EdgeConnection.Deconstruct

  • Notify the user! Discourse ticket

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.