mrkkrp / mrkkrp/parser-combinators
[Proposal] Add manyEndingWith
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 55
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
Hi! may you consider adding manyEndingWith (name subject to change)? The code would be like:
-- copy paste from manyTill_. It takes a parser p and a finalizer end. It returns the list of
-- all parsed elements with p and(!) the element parsed with end
manyEndingWith :: MonadPlus m => m a -> m a -> m [a]
manyEndingWith p end = go id
where
go f = do
done <- optional end
case done of
Just done' -> return $ f [done']
Nothing -> do
x <- p
go (f . (x :))
This is particulary usefull when parsing the eof. For example in megaparsec this code will hang forever
-- This hangs forever. But I don't know why.
my_parser = (True <$ symbol ";") <|> (True <$ symbol "|") <|> (False <$ eof)
parse (many my_parser) "" ";|"
> hangs forever...
Ideally the last example could return Right [True, True, False], but I think it isn't possible with the current combinators. With the new combinator the above example could be rewritten as
my_parser = (True <$ symbol ";") <|> (True <$ symbol "|")
parse (manyEnding my_parser (False <$ eof)) "" ";|"
> Right [True, True, False]
I know manyTill_ exists but, It returns m ([a], end), forcing you to append end at the end of the list (if a ~ end), which is inefficient for linked lists.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by reviewing the existing manyTill_ combinator and the proposed manyEndingWith implementation. Check the EOF and infinite-loop examples to decide the API and semantics, then verify that the chosen behavior returns the final parsed element in the list without hanging.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100