mrkai77 / mrkai77/Loop

🐞 Fix trigger key being re-added after import

Open
#1,080 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug
Dominant language
Swift
Stars
11.6k
Forks
270
Avg merge
8h 7m
Merged PRs (30d)
3

Description

Bug Description

Prevent automatic assignment of a trigger key when importing shortcuts.
Allow keybindings to work with shortcut combinations only, without
requiring a trigger key.

keybinds

{
  "actions" : [
    {
      "direction" : "Center",
      "keybind" : [
        8,
        58,
        59
      ]
    },
    {
      "anchor" : 8,
      "direction" : "Custom",
      "height" : 50,
      "keybind" : [
        51,
        58,
        59
      ],
      "name" : "Reasonable Size",
      "positionMode" : 0,
      "sizeMode" : 0,
      "unit" : 1,
      "width" : 50
    },
    {
      "cycle" : [
        {
          "direction" : "BottomHalf",
          "keybind" : [

          ]
        },
        {
          "direction" : "BottomThird",
          "keybind" : [

          ]
        },
        {
          "direction" : "BottomTwoThirds",
          "keybind" : [

          ]
        }
      ],
      "direction" : "Cycle",
      "keybind" : [
        58,
        59,
        125
      ],
      "name" : "Bottom Cycle"
    },
    {
      "cycle" : [
        {
          "direction" : "LeftHalf",
          "keybind" : [

          ]
        },
        {
          "direction" : "LeftThird",
          "keybind" : [

          ]
        },
        {
          "direction" : "LeftThreeFourths",
          "keybind" : [

          ]
        },
        {
          "direction" : "LeftTwoThirds",
          "keybind" : [

          ]
        }
      ],
      "direction" : "Cycle",
      "keybind" : [
        58,
        59,
        123
      ],
      "name" : "Left Cycle"
    },
    {
      "cycle" : [
        {
          "direction" : "RightHalf",
          "keybind" : [

          ]
        },
        {
          "direction" : "RightThird",
          "keybind" : [

          ]
        },
        {
          "direction" : "RightThreeFourths",
          "keybind" : [

          ]
        },
        {
          "direction" : "RightTwoThirds",
          "keybind" : [

          ]
        }
      ],
      "direction" : "Cycle",
      "keybind" : [
        58,
        59,
        124
      ],
      "name" : "Right Cycle"
    },
    {
      "cycle" : [
        {
          "direction" : "TopHalf",
          "keybind" : [

          ]
        },
        {
          "direction" : "TopThird",
          "keybind" : [

          ]
        },
        {
          "direction" : "TopTwoThirds",
          "keybind" : [

          ]
        }
      ],
      "direction" : "Cycle",
      "keybind" : [
        58,
        59,
        126
      ],
      "name" : "Top Cycle"
    },
    {
      "direction" : "Maximize",
      "keybind" : [
        36,
        58,
        59
      ]
    },
    {
      "direction" : "NextScreen",
      "keybind" : [
        56,
        58,
        59,
        124
      ]
    },
    {
      "direction" : "PreviousScreen",
      "keybind" : [
        56,
        58,
        59,
        123
      ]
    }
  ],
  "triggerKey" : [
    63
  ],
  "version" : "1.4.2"
}

Affected Scope

Other

Steps to Reproduce

https://github.com/user-attachments/assets/2db30207-9fd9-416c-98ea-2b551a97a761

Reproducibility

Always

Expected vs Actual Behavior

Expect trigger key to remain unset

Screen Recordings / Screenshots

No response

Severity

Blocker (cannot proceed)

macOS Version

Tahoe 26.4 (25E246)

Loop Version

1.4.2 (1693)

Did You Try the Development Build?

No

Additional Context

No response

Final Checks
  • My issue is written in English.
  • My issue title is descriptive.
  • This is a single bug (multiple bugs should be reported individually).
  • I have looked to see if this is a duplicate of another bug report.
  • I can help with further investigation.
  • I can help with developing a fix for this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the shortcut import path and how the imported triggerKey is handled, using the JSON example and reproduction recording to reproduce the behavior. Done means an import with an unset trigger key keeps it unset and shortcut combinations continue to work without one; verify this on the affected macOS and Loop versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.