mpv-player / mpv-player/mpv

--merge-files doesn't work with per-file option

Open
#9,522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version 0.34.0-16-gec16769c2d
  • Platform and Version Windows 10 19.43.1288
  • Source of the mpv binary shinchirol's build

If you're not using git master or the latest release, update.
Releases are listed here: https://github.com/mpv-player/mpv/releases

Reproduction steps

Run mpv --no-config --{ a.mkv b.mkv --merge-files --}

Expected behavior

The two files are merged into one file.

Actual behavior

There are two separated files in playlist.
BTW, if --merge-files is out of --{ }--, mpv --no-config --{ a.mkv b.mkv --} --merge-files for example, its behavior is as expected.

Log file

t1.log (work)
t2.log (not work)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the two mpv --no-config --{ ... --} command forms and compare the attached working and failing logs. Trace the command-line handling of --merge-files and per-file options; done means the in-scope form merges a.mkv and b.mkv into one playlist entry while the existing outside-scope form still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.