mpv-player / mpv-player/mpv

Allow resuming playback in `on_unload` hook

Open
#8,894 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

I had some cases of wanting to modify the current playlist / file state in the end of the current file but it doesn't seem to be currently possible.
From the hooks documentation, the closest thing to it is the on_unload hook which doesn't work because of the this limitation:

It's not possible to resume playback in this state

Not sure if this is due to complexity or if there is something else that would make this feature infeasible.

Alternative behavior of the wanted feature

A different hook that would be ordered before the end-file event but allow resuming playback.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the hooks documentation and compare the on_unload hook with the end-file event. Determine whether playback can resume after on_unload while allowing playlist or file state changes, or whether a new hook before end-file is needed. Done means documenting or implementing a feasible behavior with its ordering and resume semantics.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.