mpv-player / mpv-player/mpv

quit command stops but doesn't quit in encoding mode (--o=...)

Open
#8,754 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:encoding
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version Latest release.
  • Platform and Version Windows 10 & Ubuntu 20.04
Reproduction steps

Start mpv in encoding mode and encode a playlist of media files.
Either setup a timed event in a lua script or issue a command via IPC to quit after approximately 1 minute.

Expected behavior

mpv should immediately quit.

Actual behavior

mpv stops but does not quit, process stays alive.

Log file

Log file provides no clues. In this example I send the quit command at approx 10 seconds, but nothing is recorded in the log:

mpv-2021-03-19-10-43-49-71.log

Note - the log file uses a custom build of mpv but the results are identical in the latest release. I've noticed this bug since I began using mpv for encoding (since March 2020 builds, this problem likely has been around for much longer)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing encoding mode with --o=... and send the quit command from a Lua timed event or through IPC. Trace why mpv stops encoding but leaves the process alive; done means the same quit command immediately terminates mpv in the reported Windows and Ubuntu scenarios.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, lua
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.