mpv-player / mpv-player/mpv

OSD displaying wrong edition title when cycling edition.

Open
#8,656 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:option-param-conf
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

mpv version: 0.33.0
Platform: Windows 7
Source of the mpv binary: Chocolatey
Issue can be reproduced with --no-config

Reproduction steps

Play mkv file with two or more editions.
During playback press default keybind 'E' to cycle edition.
Look at the OSD displaying the edition title.

Expected behavior

I would expect the title of the edition now starting playback to pop up.

Actual behavior

The title of the edition that was just played pops up. The one we just left.

Log file

log file

Sample files

MKV with Three Editions

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked MKV containing three editions, using the default E keybind and --no-config; review the linked output.txt log while cycling editions. Trace the edition-cycle and OSD update entry points, then verify that the title shown is for the edition that begins playback rather than the one just left.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.