mpv-player / mpv-player/mpv

run command in input.conf doesn't quit anymore

Open
#8,377 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core core:option-param-conf os:linux
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version

mpv 0.33.0-31-gb8156a9a86

  • Linux Distribution and Version

Ubuntu 20.04.1

  • Source of the mpv binary

Compiled locally using mpv-build

  • If known which version of mpv introduced the problem

It worked before I upgraded from Ubuntu 18.04 to 20.04, which seems to have updated mpv as well.

  • Window Manager and version

i3 version 4.19 (2020-11-15)

Reproduction steps
  • Add i run "/bin/sh" "-c" "echo ${working-directory} ${path} | dzen2 -p 1 -y 200" to input.conf.
  • Hit 'i' while watching a video
  • The dzen2 box doesn't disappear after one second as -p 1 tells it to.
  • Calling the above echo ... | dzen2 -p 1 from the command line does work as expected (and used to work in mpv also).

Same problem occurs without using /bin/sh:

My input.conf file used to do it this way:

i run "mpv-info" "${working-directory}" "${path}"

where mpv-info is just a script that calls dzen2 with its -p parameter to automatically exit after a certain period of time. This used to work and a call to mpv-info still works if called from the command line.

Expected behavior

dzen2 -p 1 should self-terminate after one second.

Actual behavior

dzen2 persists longer than one second, persists after mpv is closed, and has to be killed with kill -9

Log file

output.txt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the input.conf run command while watching a video, then compare it with the same dzen2 command run directly from the shell. Start with the linked output.txt and the run command entry point; done means dzen2 honors -p 1 and does not remain after mpv exits.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, shell
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.