mpv-player / mpv-player/mpv

Automatic ICC retrieval fails on 2 monitor setup

Open
#8,349 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:color-management os:linux vo:gpu:x11
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version 0.33.0
  • Linux Distribution and Version Gentoo latest
  • Source of the mpv binary 0.33.0
  • If known which version of mpv introduced the problem
  • Window Manager and version xfwm4
  • GPU driver and version Intel, linux 5.9.8, mesa 20.1.10
  • Possible screenshot or video of visual glitches
  • Colord 1.3.5

On main display, 2 display setup:
image

On secondary display, 2 display setup:
image

On secondary display, 1 display setup:
image

Reproduction steps

First, connect second display, configure ICC on it using XICCD, and xfce4-color-settings, or any colord compatible config UI

Second, try starting MPV on both displays. Secondary display will always fail to load ICC.

Now, disable the main display, and try starting MPV again. It will autoload the profile just fine.

Expected behavior

ICC loading should work on any number of displays.

Actual behavior

ICC autoloading fail on non-main display. I very much suspect some very simple arithmetic issue on the side of either the code that pulls ICC from colord, or colord itself, where it gets the wrong display number.

Log file

Fail: https://0x0.st/i7Tj.txt

Success: https://0x0.st/i7Te.txt

Success, secondary display set as main: https://0x0.st/i7T2.txt

Fail, primary display unset as main: https://0x0.st/i7TL.txt

The issue will be closed for ignoring the issue template.

Sample files

Sample files needed to reproduce this issue can be uploaded to https://0x0.st/
or similar sites. (Only needed if the issue cannot be reproduced without it.)
Do not use garbage like "cloud storage", especially not Google Drive.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two-monitor setup described in the issue and compare the linked failing and successful logs, focusing on ICC retrieval through colord. Done means ICC autoloading works on the secondary display while the main display remains enabled, without changing the reported setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.