mpv-player / mpv-player/mpv

Option to set subtitle depth for 3D playback

Open
#8,308 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:subtitle core:video meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

There's currently no feature that would allow us to set the depth of the subtitles when rendered in 3D playback mode. The subtitle is duplicated correctly to show up for both images but since it's rendered in the exact same location on both images its depth will be the depth of the screen.

There should be an option that moves the different instances of the rendered subtitles relative to each other on the x axis, thereby moving them forward or backward relative to the screen depth in 3D playback modes. Implementation shouldn't be more difficult than adding the options' value (or some scaled version of it) to the x position of one of the subtitle instances and substracting it from the other. Default value is 0 to result in current behaviour.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the subtitle-rendering path used during 3D playback and trace how the two subtitle instances are positioned. The work is done when a configurable depth value offsets the instances in opposite x directions, while the default value preserves current behavior; add or run the relevant playback tests if that path has coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.