track selection is broken in specific cases
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
mpv version and platform
git master
Reproduction steps
- run "mpv --sid=1 1.mp4"
- run command "sub-add 2.ass auto"
- run command "set sid 1"
Expected behavior
Subtitle track 1 is selected.
Actual behavior
No subtitle track is selected. The option value of sid is already set to 1, so no option change event is emitted, no track will be selected. It can happen when the sid is set from the watch later file, and dynamically load and select subtitle files from scripts.
related commit fba7c69b8afe7a2c06f14b7fc96b53b1a55819cf
Log file
none
Sample files
none
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the command sequence in the issue: launch mpv with --sid=1, run sub-add 2.ass auto, then set sid 1. Read the track-selection handling and related commit fba7c69b8afe7a2c06f14b7fc96b53b1a55819cf. Done means the existing sid value still causes subtitle track 1 to be selected after the dynamically added track.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100