Stats overlay lingers when keeping key down
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
mpv version and platform
mpv 0.29.1 Copyright © 2000-2018 mpv/MPlayer/mplayer2 projects
built on Sun Dec 9 16:21:27 CET 2018
ffmpeg library versions:
libavutil 56.22.100
libavcodec 58.35.100
libavformat 58.20.100
libswscale 5.3.100
libavfilter 7.40.101
libswresample 3.3.100
ffmpeg version: n4.1
Reproduction steps
Play a file and keep i pressed down for some time. Release the key.
Expected behavior
After releasing i, the stats overlay stays visible for the duration script-option of stats.lua.
Actual behavior
The stats overlay stays visible for duration plus some time depending on how long the key was kept down.
This is probably happening because key repetition events happen faster than the redraw of the stats, so events get backed up. Drawing in an idle handler could solve this.
Log file
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading stats.lua and tracing how repeated i-key events reach the stats overlay. Reproduce the issue by holding i, then release it and compare the overlay lifetime with the configured duration; done means key repetition no longer extends that lifetime.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100