mpv-player / mpv-player/mpv

hdr-compute-peak changes the brightness unaturally with subtitle.

Open
#6,368 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:color-management
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

mpv version and platform

mpv 0.29.1 Copyright © 2000-2018 mpv/MPlayer/mplayer2 projects
built on UNKNOWN
ffmpeg library versions:
libavutil 56.23.101
libavcodec 58.39.100
libavformat 58.22.100
libswscale 5.4.100
libavfilter 7.44.100
libswresample 3.4.100
ffmpeg version: 4.1.git

Reproduction steps

Play HDR movie.

Expected behavior

hdr-compute-peak doesn't change the brightness when the subtitle comes out.

Actual behavior

When the subtitle comes out, the image becomes so dim, the video is not watchable.

Log file

https://0x0.st/sDO8.txt

Sample files

2018-12-10 09-51-59
2018-12-10 09-52-29

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction steps for an HDR movie and inspect the linked log file alongside the hdr-compute-peak behavior when subtitles appear. Trace the HDR brightness calculation and subtitle interaction; done means subtitles no longer make the image unwatchably dim while hdr-compute-peak is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.