mpv-player / mpv-player/mpv

--autofit and -–geometry are only half the size on Retina display.

Open
#4,218 25 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

core core:option-param-conf os:mac
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Reproduction steps

Use --autofit=480

Expected behaviour

The window is 480 pixels wide.

Actual behaviour

The window is 240 pixels wide.

Notes

Work correctly on commit 85c8556 (built on Sat Mar 4 18:34:51 GMT 2017)

mpv version and platform

OS X 10.11.6 (15G1217) on a MacBook Pro (Retina, Mid 2012)

mpv git-076116a (C) 2000-2017 mpv/MPlayer/mplayer2 projects
 built on Fri Mar 10 17:31:43 GMT 2017
ffmpeg library versions:
   libavutil       55.34.101
   libavcodec      57.64.101
   libavformat     57.56.101
   libswscale      4.2.100
   libavfilter     6.65.100
   libswresample   2.3.100
ffmpeg version: 3.2.4
Log file

Running mpv --no-config --no-osc --no-load-scripts --log-file=output.txt z.webm --autofit=480

http://sprunge.us/OVEa

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing mpv --autofit=480 on the reported Retina macOS setup and compare it with commit 85c8556. Trace the handling of --autofit and --geometry, including display scaling, then verify that a requested width of 480 produces a 480-pixel window on Retina displays.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, macos
Domain
cli, desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.