Sub-pos only moves up from where the set position is?
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
mpv version and platform
Sourceforge latest.
Windows 10
Expected behavior
While using sub-margin-y=40 I expected the keybind add sub-pos +1 to move the subs down from their original position.
Actual behavior
Instead they don't move down from their original position unless you've move them up using add sub-pos -1
https://2.lithi.io/xPC8p.webm
https://9.lithi.io/JjJ8k.webm
Log file
Don't really think we need one, unless this is a bug.
I know that you can just use sub-margin-y=0 but that would require for me to always have the subs at the bottom of the video, personally I do not like that and I would always be having to mess with the position of my subs, what I want is to be able to use sub-margin-y=40 and be able to use the keybind add sub-pos +1 to move it lower than the set position.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the sub-pos keybind and sub-margin-y option handling in the mpv source, reproducing the behavior described on Windows 10. Done means add sub-pos +1 can move subtitles below the configured sub-margin-y=40 position while preserving the expected movement in the opposite direction.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100