mpv-player / mpv-player/mpv

Make OSD progress bar's completed section color configurable or solid white

Open
#2,579 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:option-param-conf core:osd meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

On a white background, the default progress bar basically consists of a single black line separating watched from unwatched.

That doesn't really stand out as much as one might hope. It would be nice to have the completed and uncompleted sections be more distinctly colored.

The uncompleted section doesn't actually have a color, so I used to use osd-back-color="#77000000" to give it a gray color, which stood out nicely against the solid white of the completed section.

But sometime in the past year the progress bar's completed section started using what appears to be a non-transparent version of the back-color and now the difference between completed and uncompleted can be impossible to see on a white background.

I recommend:

  • User can set a color for the completed section of the progress bar.
  • If no color is set, use solid white not the back-color.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the OSD progress bar implementation and the osd-back-color option. Trace how the completed and uncompleted sections currently derive their colors, then assess the requested configurable completed color or solid-white fallback. Done means the two sections remain visibly distinct on a white background and the existing option continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.