Some `OSD` Info cannot be quickly closed via `ESC`
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
mpv Information
mpv v0.41.0 Copyright © 2000-2025 mpv/MPlayer/mplayer2 projects
libplacebo version: v7.360.1
FFmpeg version: 9.0.1
FFmpeg library versions:
libavcodec 63.1.101
libavdevice 63.1.101
libavfilter 12.1.101
libavformat 63.1.101
libavutil 61.1.101
libswresample 7.1.101
libswscale 10.1.101
Reproduction Steps
Use the shortcut key ? to display Active Key Bindings, you can use ESC to close OSD at any time.
Now using the shortcut key i will also display Active Key Bindings and disappear automatically after about 4-5 seconds, during this period, you cannot quickly close OSD via the ESC key.
In fact, the shortcut key i corresponding to command script-binding stats/display-stats only displays the last entered stats page (1-5), and automatically closes after 4-5 seconds.
I know I can change it to e.g. script-binding stats/display-page-1-toggle and then it won't close automatically but I can use ESC to close at any time.
The problem is when I click on the filename in OSC, it also shows stats page5 and closes after 4-5 seconds, but cannot be closed via ESC.
Sometimes I just want to check briefly, or just accidentally click, and not being able to close via ESC is annoying, and it seems to behave inconsistently with other commands/entry methods.
I know that in both cases they close automatically after 4-5 seconds, but why not allow me to close earlier via ESC?
Expected Behavior
I hope that ESC can consistently quickly closes the current OSD floating layer under any circumstances.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the i shortcut's script-binding stats/display-stats entry point and the OSC filename-click path, then compare them with display-page-1-toggle and the ESC handling for OSD. Reproduce both cases and make the current OSD close consistently with ESC while retaining the existing automatic timeout behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100