mpv-player / mpv-player/mpv

Pick forced subs for audio tagged as multiple languages

Open
#18,411 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

Although this is not strictly adhering to the specs, there are many files out there which have audio tagged as multiple languages (language code mul) and subtitles tagged with forced=yes that are meant to go along with it. As such, I believe mpv should special case this code and still select them, picking the first forced track.

Example case:

  • audio is mostly 95% English and 5% German, tagged as mul
  • forced English subtitles cover only the handful of German lines, tagged language=eng, default=no, forced=yes

Currently mpv does not pick those subtitles by default. I believe it would be beneficial if it did.

Alternative behavior of the wanted feature

No response

Log File

log.txt

Sample Files

https://x0.at/HnU9.mkv

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Reproduce the behavior with the linked MKV sample and inspect mpv's subtitle-selection path for audio tagged with language code mul. Done means the first forced subtitle track is selected by default for that audio case.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.