mpv-player / mpv-player/mpv

add multiplier to hdr-compute-peak darkening/brightening (more control, finetuning)

Open
#18,331 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

Hi, I would like to have more control over hdr-compute-peak I don't know how internally the values look like, if there is a positive value for boost and a negative for cut, or if there are different variables for them but essentially what I would like is to "simply" add a multiplier to the boost and cut value. For example you can put multiply 2 for boost hdr-compute-peak-multiply-boost=2, which would make the picture twice as bright in the darkest section, but this would not affect the cut/darkening behaviour, so the bright stuff stays as it is.
So you would have the options:

hdr-compute-peak-multiply-boost
hdr-compute-peak-multiply-cut

I hope this makes sense.

Thanks for any help :)

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the hdr-compute-peak option and the code that applies its HDR boost and cut values. Read the surrounding HDR processing logic and existing tests, if present; done means independent boost and cut multipliers are exposed and each changes only its corresponding behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.