mpv-player / mpv-player/mpv

Magic Kernel Sharp (Classic, 2013, and 2021) resampling filter for upscaling filter

Open
#18,288 10 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

Magic Kernel Sharp is a resampling algorithm by John Costella. There are Classic, 2013 and 2021 versions so add all three. The website is https://johncostella.com/magic/ and it describes its use. I'm wanting it implemented as I like resampling filters (ones with math) and MPV and MPV Android have never had this one before. Read the website for a more detailed explanation.

https://github.com/Viddeleer/Image-Processing has a C++ implementation of the upscaling filter (resampling methods) and Magic Kernel Sharp would be useful for both the Android and Windows versions of MPV. Currently Magic Kernel Sharp is in no MPV version, even on Android. ImageMagick has added Magic Kernel Sharp due to being a resampling algorithm, and I got the developer of https://github.com/T8RIN/ImageToolbox to add Magic Kernel Sharp too.

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the Magic Kernel Sharp description at johncostella.com/magic/ and compare the C++ implementation in Viddeleer/Image-Processing. Then locate mpv’s existing upscaling resampling-filter integration point and determine how the Classic, 2013, and 2021 variants fit there. Done means all three filters are available for mpv’s upscaling path and their behavior is covered by appropriate validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.