mpv-player / mpv-player/mpv

Expand option -sub-gray to allow conversion image subtitles (PGS) from white to gray

Open
#16,629 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

We have an existing option to convert yellow image subtitles to gray. However, I would also like to use this option to convert white PGS subtitles as well. The reason is that Valerion and other new DLP based projectors use dynamic black level algorithms to improve the overall black level of DLP projectors (which traditionally don't offer good blacks). However, white subtitles mess up with the algorithm leaving the detection disabled and raising blacks. So my ask is:

P0: Expand -sub-gray option to handle white -> gray conversion.
P1: Allow the user to define the shade of gray and transparency level.

Thanks!

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the mpv source for the -sub-gray option and the existing yellow image-subtitle conversion path, then trace how PGS subtitles are handled. Done means white PGS subtitles can be converted to gray through -sub-gray; the requested configurable gray shade and transparency level are a separate P1 enhancement.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.