`sub-hdr-peak` Add Option to Ignore Signs
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
Expected behavior of the wanted feature
Recent commits added a very useful feature for subtitles peak for HDR output via sub-hdr-peak, but there is an improvement that can be added as it currently affects all subtitles which results in some undesired situations with subtitle masking on signs when it is not set to default sub-hdr-peak=sdr.
This is similar to this issue with inverse tonemapping which remains unresolved:
https://github.com/mpv-player/mpv/issues/13680#issuecomment-1987410908
The improvement to this feature should add an option to only have it affect the main dialogue text - perhaps similar to the logic employed by sub-ass-override so signs can blend properly regardless of what brightness the subtitles are set to.
Alternative behavior of the wanted feature
No response
Log File
No response
Sample Files
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing sub-hdr-peak handling and compare it with the sub-ass-override logic referenced in the issue. Done means the new option affects only main dialogue text while signs blend correctly regardless of subtitle brightness settings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100