mpv-player / mpv-player/mpv

Keypad bindings, add rotate and change location of zoom

Open
#15,417 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

Since recently the keypad got utilized more, but also broke some behavior. As I explored the new keybindings on the keypad, they seem somewhat unnatural to me.
The video scale is fine with: down KP2, up KP8, left KP4 and right KP6.

Though the zoom-in on KP9 and zoom-out on KP1, diagonally opposite to each other seam somewhat unhandy. There was also a discussion to add rotate to the keybindings, but these don't seem to work for me.

My proposal would be to

set zoom on KP7 and KP9

set rotate on KP1 and KP3, preferably with 45° (or 22.5°) angles left and right

as KP3 and KP7 are unbound at the moment.

KP0 is also unbound and could be used as a reset and KP. could be used as an 'unreset/undo recent reset'.

Alternative behavior of the wanted feature

No response

Log File

No response

Sample Files

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing mpv's existing keypad bindings and the behavior discussed in issues #15416 and #5458. Compare the proposed zoom, rotate, reset, and undo mappings with the currently unbound keys, then verify that the agreed bindings and rotation behavior work consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.