mpv-player / mpv-player/mpv

Road to Hell - Changing FPS

Open
#15,343 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

mpv Information

No response

Important Information
All versions of MPV
Reproduction Steps

Simply changing the FPS of media (and adding pitch) manually is more complex than it needs to be.

Problem:
Change 23.976 to 24 and normalize audio

Solution:

[23.976 to 24]
profile-cond=container-fps=23.976
speed=1.001001
pitch=1.001001
audio-pitch-correction=no
af-add=rubberband=pitch-scale=0.999,engine=finer
sub-speed=24/23.976 (this value will work with speed/pitch too ?)
sub-fps=24

Proposed solution:
If mpv can handle conditions, how about the following:

fps-cond = 23.976 = 24
audio-pitch-correction = hd
sub-??? = video-out-fps

Additionally it would be nice to hold one frame longer instead of repeating it. hold-cond = 24 = 2 for example would output 24 frames in 2 seconds instead of bobbing the output to 48 frames (reduces CPU/GPU usage)

Also I want to mention that the manual is very confusing on this topic, see image attached:

IMG_20241120_221224

Expected Behavior

Simple and straightforward

Actual Behavior

Not simple and straightforward

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies no source file, test, or entry point. Start by tracing mpv's existing profile-cond, speed, pitch, subtitle-speed, and audio-filter options, then clarify how the proposed FPS and frame-holding conditions should interact. Done would require an agreed scope, documented behavior, and tests covering timing, audio pitch, subtitles, and frame output.

Written by the indexing model from the issue text.

Assessment

Domain
cli, performance
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.