Font size of OSD, subtitles, ... should depend on window width instead of window height
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
Expected behavior of the wanted feature
It would be helpful if the things shown on OSD (e.g. playlist via F8), subtitles, etc... would better fit on the window on all aspect ratios (portrait or landscape).
When watching a "portrait" video (like youtube shorts), the font is huge, causing so many line breaks that you can't see more than 1 or 2 playlist items, subtitles fill almost the whole video, ...
It seems like the window height determines some font size factor (in addition to the --osd-font-size argument). Before the "portrait" videos were a thing, the width always was within a reasonable range depending of the height, but this has changed.
I've tested quite a few different --osd-font-size values, but in a mixed playlist, I always get either a way too tiny font on "landscape" videos or a way too huge font on "portrait" videos. When the font size is determined by width instead of height, it still varies, but fits much better.
You can test this by downloading any youtube videos in mixed formats, e.g. using youtube-dl and playing them in one playlist.
Alternative behavior of the wanted feature
No response
Log File
No response
Sample Files
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how --osd-font-size is applied to OSD elements and subtitles, including the playlist shown with F8. Reproduce the issue with a mixed playlist of portrait and landscape videos, then verify that sizing based on window width fits both orientations without excessive line breaks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100