mpv-player / mpv-player/mpv

libmpv: missing MPV_EVENT_END_FILE event when playing video from yt-dlp_x86

Open
#14,913 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

mpv Information
[ 118.039][v][cplayer] mpv v0.38.0-601-gf470b63a Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
[ 118.039][v][cplayer]  built on Jul 12 2024 00:08:04
[ 118.040][v][cplayer] libplacebo version: v7.349.0 (v7.349.0-dirty)
[ 118.040][v][cplayer] FFmpeg version: N-116241-g70c6b904b
[ 118.040][v][cplayer] FFmpeg library versions:
[ 118.040][v][cplayer]    libavcodec      61.10.100
[ 118.040][v][cplayer]    libavdevice     61.2.100
[ 118.040][v][cplayer]    libavfilter     10.2.102
[ 118.040][v][cplayer]    libavformat     61.5.101
[ 118.040][v][cplayer]    libavutil       59.28.100
[ 118.040][v][cplayer]    libswresample   5.2.100
[ 118.040][v][cplayer]    libswscale      8.2.100
Other Information
- Windows version:Windows 10 Pro 64-bit (10.0, Build 19045) (19041.vb_release.191206-1406)
- GPU model, driver and version:AMD Radeon(TM) Graphics 31.0.21914.4000
- Source of mpv: https://github.com/wbtcpip2/mpv-winbuild/releases/tag/2024-07-12-f470b63
- Introduced in version: since longtime
Reproduction Steps

start playing a youtube video with libmpv and check the mpv_wait_event
when the video has finished you do not receive the MPV_EVENT_END_FILE (so my app remain stalled waiting forever for MPV_EVENT_END_FILE)
However the log generated show the eof file at the end
MPV_EVENT_END_FILE is always received when playing non yt-dlp_x86 streams

Expected Behavior

to receive the MPV_EVENT_END_FILE event at the end of a video played from yt-dlp_x86

Actual Behavior

MPV_EVENT_END_FILE event not received when playing streams from yt-dlp_x86

Log File

24092024_160742_httpswww3bmeteocommeteobasilicatavideo.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:
  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the libmpv mpv_wait_event entry point and review how MPV_EVENT_END_FILE is delivered for yt-dlp_x86 playback. Reproduce the issue with the attached log and compare it with a non-yt-dlp_x86 stream. Done means the event is received after the video ends without changing the existing behavior for other streams.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.