mpv-player / mpv-player/mpv

spam msg of video-crop

Open
#14,807 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:win
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

mpv Information
mpv v0.38.0-743-gad7976c3 Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on Sep  4 2024 20:07:30
libplacebo version: v7.349.0 (v7.349.0-9-gefb8934-dirty)
FFmpeg version: N-116858-geda3fc605
FFmpeg library versions:
   libavcodec      61.11.100
   libavdevice     61.2.100
   libavfilter     10.2.102
   libavformat     61.5.101
   libavutil       59.35.100
   libswresample   5.2.100
   libswscale      8.2.100
Other Information
- Windows version: 11 release
- GPU model, driver and version: rtx4080 latest stable driver
- Source of mpv: build by myself
- Introduced in version: n/m
Reproduction Steps

open a 4k video with vf=format=fmt=nv12:convert=yes:w=1920:h=1080

Expected Behavior

No spam msg in console/log

Actual Behavior
...
[  10.277][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.277][v][cplayer] Set property: video-crop -> 1
[  10.278][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.278][v][cplayer] Set property: video-crop -> 1
[  10.279][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.279][v][cplayer] Set property: video-crop -> 1
[  10.280][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.280][v][cplayer] Set property: video-crop -> 1
[  10.281][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.281][v][cplayer] Set property: video-crop -> 1
[  10.282][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.282][v][cplayer] Set property: video-crop -> 1
[  10.283][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.283][v][cplayer] Set property: video-crop -> 1
[  10.283][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.283][v][cplayer] Set property: video-crop -> 1
[  10.283][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.283][v][cplayer] Set property: video-crop -> 1
[  10.284][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.284][v][cplayer] Set property: video-crop -> 1
[  10.285][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.285][v][cplayer] Set property: video-crop -> 1
[  10.286][w][vo/gpu] Ignoring invalid --video-crop= for 1920x1080 image
[  10.286][v][cplayer] Set property: video-crop -> 1
...
Log File

test.log

Sample Files

n/m

I carefully read all instruction and confirm that I did the following:
  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the vf=format=fmt=nv12:convert=yes:w=1920:h=1080 filter and inspect the vo/gpu handling of --video-crop alongside the attached log. The fix is complete when this scenario no longer emits repeated invalid-crop warnings or redundant property updates in the console.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.