mpv-player / mpv-player/mpv

add built-in OSD message for command `frame-step` and `frame-back-step` to show frame number

Open
#14,341 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Expected behavior of the wanted feature

I think frame number is an important message, it's useful for compare scaling filters/shaders, open same file in two window and ensure that they are exactly in the same frame.

Try to add OSD message by myself, but the show-text shows the frame number before frame-step and frame-back-step.
e.g.
frame-step from 0 to 1, show-text shows 0 / 12345 not 1 / 12345.
frame-back-step from 1 back to 0, show-text shows 1 / 12345 not 0 / 12345.

KEY1   frame-step; show-text "${estimated-frame-number} / ${estimated-frame-count}"
KEy2   frame-back-step; show-text "${estimated-frame-number} / ${estimated-frame-count}"

So a built-in OSD message is needed, if some people don't like it, add no-osd prefix to disable it.

Alternative behavior of the wanted feature

N/A

Log File

N/A

Sample Files

N/A

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the frame-step and frame-back-step command handlers and the existing show-text OSD message path. Check how estimated frame values are evaluated relative to command execution, then verify that both commands display the resulting frame number and that the proposed no-osd behavior is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.