mpv-player / mpv-player/mpv

JPEG screenshots taken with vo=gpu-next appear darker than when taken with vo=gpu

Open
#13,995 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

vo:gpu-next
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

Reproduction steps

This is a JPEG screenshot taken by mpv --no-config using the screenshot command:
gpu

This is a screenshot taken by mpv --no-config --vo=gpu-next:
gpu-next

The JPEG screenshot taken when using gpu-next appears slightly darker, particularly around the stalactites, than the screenshot taken when using gpu. I'm not sure if screenshot-tag-colorspace affects JPEG screenshots, but just to rule it out, setting --screenshot-tag-colorspace=no does not have any impact.

Expected behavior

JPEG screenshots should have the same brightness.

Actual behavior

There is a difference in brightness between gpu-next and gpu.

Log file

log.txt

Sample files

Any video file should work, but it is easiest to see the difference when taking screenshots with scenes that are set in low light.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with mpv v0.38.0-63-gb364e4a6 on Windows 10 using the screenshot command with vo=gpu and vo=gpu-next, including the linked log and a low-light video scene. Compare the JPEG screenshot paths and color handling; done means both renderers produce screenshots with the same brightness, including around the stalactites.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.