mpv-player / mpv-player/mpv

When setting subtitle id with --sid the option becomes ignored after switching subtitles once and then switching files

Open
#13,670 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:linux
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version = v0.37.0-280-gf746125769-dirty
  • Linux Distribution and Version = Arch Linux
  • Source of the mpv binary = self compiled
  • GPU model, driver and version = not sure
Reproduction steps

Use the following files: https://nyaa.si/view/1771619
Queue several files on the command line and pass --sid=3 (or any other value other than what's automatically selected).
Change to subtitle ID 4 with j, and then change back to subtitle ID 3 with J.
Go to the next file in the queue (with enter or >).
Try changing the subtitle, you'll find that somehow subtitle ID has been set to 2 instead of the 3 selected on the command line

Expected behavior

Subtitle ID stays what is selected on the command line.

Actual behavior

Subtitle ID gets reset to the automatically selected subtitle ID.

Log file

output.txt

Sample files

https://nyaa.si/view/1771619

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the queued-file sequence with --sid=3, switching subtitles with j and J, then advancing with enter or >. Trace the subtitle selection state across the file switch and compare it with output.txt; done means the selected subtitle ID remains 3 and can still be changed after advancing to the next file.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.