Aspect Ratio applied wrong with MKV Crop value
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
Important Information
Provide following Information:
- mpv-x86_64-v3-20240301-git-8ba6d8f
- Windows 11 23H2 26020.1000
Reproduction steps
Add mkv container crop values on e.g. 4:3 PAR videos (Crop = 10,2,8,4)
Expected behavior
Cropping after aspect ratio correction is applied
720x576 SAR > 768x576 PAR > 750x570 Crop
Actual behavior
720x576 SAR > 702x570 Crop > 736x570
Addional mpv reports a crop of X=10, Y=2 instead of 10,2,8,4 (but this is only a ui problem)
Sample files
Original
Bug
Correct
Sample Video
video.zip
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported behavior with the linked sample video and the MKV crop values, then trace mpv's aspect-ratio correction and crop handling. Compare the expected and actual transformation order, and verify that the reported crop values also represent all four values once the behavior is corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100