mpv-player / mpv-player/mpv

Inverse tone mapping for spline insensitive to tone mapping param

Open
#12,727 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Windows Shinchiro build.
mpv v0.36.0-627-g05e6813e Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
built on Oct 23 2023 00:24:03
libplacebo version: v6.338.0-43-ga59333c-dirty
FFmpeg version: N-112502-g6e4030a07
FFmpeg library versions:
libavutil 58.27.100
libavcodec 60.30.102
libavformat 60.15.100
libswscale 7.4.100
libavfilter 9.11.100
libswresample 4.11.100

Reproduction steps

Add inverse-tone-mapping and try to use tone-mapping-param that is not. Observe it does nothing, including with tone-mapping-visualize.

Expected behavior

Inverse tone mapping midpoint should move according to the tone mapping param.

Actual behavior

The midpoint does not change.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue on the reported Windows Shinchiro build using inverse-tone-mapping, a non-default tone-mapping-param, and tone-mapping-visualize. Compare the tone-mapping midpoint with and without the parameter; done means the midpoint moves according to tone-mapping-param.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.