mpv-player / mpv-player/mpv

MPV not honoring font size stylings for some fonts

Open
#12,411 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:win
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information
  • mpv version 0.36.0 / 20230910 Nightly (September 10, 2023)
  • Windows Version Windows 10 build 19045.3448
  • Source of the mpv binary https://www.videohelp.com/software/mpv-media-player
  • I don't know which version of mpv this bug originated in. However, I remember seeing it in an mpv version in 2017 or 18.
Reproduction steps

This can be reproduced by running mpv in default configuration and --no-config as well.
To reproduce, just play the sample video in both mpv and mpc-hc.

Expected behavior

There are 3 lines of text in 3 different fonts shown on screen. The subtitles should have the same relative size to each other regardless of what video player was used to view them.

Actual behavior

The @FOT-SeuratCapie Pro B and Kozuka Gothic Pr6N B lines are bigger relative to the Ghandi sans line in mpv compared to mpc-hc. Mpc-hc is actually displaying the fonts in their intended sizes.

This bug seems to only affect certain fonts and these are the only two I can find at present. I can't tell what causes a certain font to have this problem but not others.

Log file

Log file

Sample files

Sample video

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the font-size mismatch with the linked sample video in mpv using both default configuration and --no-config, then compare the result with mpc-hc. Review the linked log file while narrowing the issue to subtitle and font rendering behavior. Done means the three subtitle lines have the same relative sizes in mpv as in mpc-hc for the supplied sample fonts.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.