mpv-player / mpv-player/mpv

Master osc layout improvement

Open
#12,358 11 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

meta:feature-request
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

First of all, this is entirely subjective, but I thought I'd share what I think about how you could improve osc to make it more aesthetically pleasing and symmetrical.

So, progress bar definitely needs some rework to make it a bit thinner, fortunately it's a simple fix of a few values in the lua, here's what I came up with, editing this gives a nice and thin bar with clearly visible chapters

    geo = { x = sb_l, y = geo.y, an = geo.an,
            w = math.max(0, sb_r - sb_l), h = geo.h - 15}
    lo.slider.gap = 3
    lo.slider.tooltip_an = 2

That's how it looks like
image
Further on, we can move cycle_s, cycle_a, fs and vol elemets to the top title row, this change frees up space for progress bar and also makes elements and the whole osc look symmetrical and this is what I meant by aesthetically pleasing. Here's an example how it would look like in the end:
image
Please tell me what do you think about this and share some thoughts

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the OSC Lua layout and the proposed progress-bar and title-row changes. Compare the existing arrangement with the supplied screenshots and clarify the desired spacing and symmetry; done means an agreed, concrete layout change rather than a subjective proposal.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.