mpv-player / mpv-player/mpv

Make --cover-art-files support runtime changes and relative path

Open
#12,165 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information
Reproduction steps

start mpv
load an audio only file
set cover-art-files "abs-path"
no cover in video tracks

start mpv
set cover-art-files "abs-path"
load an audio only file
cover been selected and overridden embedded or external cover.

start mpv
set cover-art-files "~~/filename"`
error
image
image

Expected behavior

I want to add a fallback cover by using auto-profile with --cover-art-files, so I want it can be changes in runtime.
And to have portability, I want it support relative path.

Actual behavior

see #Reproduction steps

Log file
Sample files

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two runtime sequences with --cover-art-files and the relative-path command described in the issue. Trace the existing cover-art-files option handling and cover selection behavior; done means runtime changes take effect and relative paths work for fallback covers without overriding the reported behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.