scale=jinc shows different behaviour between vo=gpu and vo=gpu-next
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
Important Information
- mpv version: git-f76c441
- Platform and Version: Windows 11 22621.1848
- Source of the mpv binary: Shinchiro
Reproduction steps
Resampling any video/image with --scale=jinc.
Expected behavior
--vo=gpu and --vo=gpu-next should, ideally, do the same thing when you specify the same filter.
Actual behavior
--vo=gpu maps this to polar jinc while --vo=gpu-next maps it to orthogonal jinc.
To be honest, I think what --vo=gpu-next is doing is correct here given the entry is called "jinc" and not "ewa_jinc". Maybe the ideal solution would be simply adding "ewa_jinc" as a different entry to make it unambiguous.
Log file
I don't think this is necessary.
Sample files
This isn't necessary either.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how --scale=jinc is interpreted by the --vo=gpu and --vo=gpu-next paths. Compare their polar and orthogonal mappings, then confirm that the completed change makes the filter naming and behavior unambiguous between both video outputs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100